Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff: ignore E501 #832

Merged
merged 1 commit into from
Jul 27, 2023
Merged

ruff: ignore E501 #832

merged 1 commit into from
Jul 27, 2023

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Jul 27, 2023

Change Summary

Ignores ruff E501 since we use black to manage that.

Related issue number

We did a similar change in pydantic/pydantic#6552

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

@davidhewitt
Copy link
Contributor Author

please review

@davidhewitt davidhewitt enabled auto-merge (squash) July 27, 2023 12:02
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #832 (4c941b7) into main (ce34622) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #832   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files         102      102           
  Lines       14606    14606           
  Branches       25       25           
=======================================
  Hits        13655    13655           
  Misses        945      945           
  Partials        6        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce34622...4c941b7. Read the comment docs.

@davidhewitt davidhewitt merged commit 956f996 into main Jul 27, 2023
28 checks passed
@davidhewitt davidhewitt deleted the dh/ruff branch July 27, 2023 12:07
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 27, 2023

CodSpeed Performance Report

Merging #832 will not alter performance

Comparing dh/ruff (4c941b7) with main (ce34622)

Summary

✅ 135 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants