Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The goal here is to remove all uses of
unsafe
which I could replace with safe code, or alternatively justify with aSafety
comment. The changes make use of safe abstractions which should completely optimize away (especially with full LTO) so no performance impact is expected.The only exception is that there were some uses of
PyByteArray::as_bytes
which I didn't agree with as appropriate, and I copied the output of those cases into a new allocation. This is a necessary performance loss in exchange for correctness.Related issue number
Related to pydantic/pydantic#7211 - doing some due diligence here felt worthwhile.
Checklist
pydantic-core
(except for expected changes)Selected Reviewer: @samuelcolvin