Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: use stdlib and remove useless code #86

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

eumiro
Copy link
Contributor

@eumiro eumiro commented Aug 11, 2023

Extends pydantic/pydantic#7082 and replaces pydantic/pydantic#7080

Selected Reviewer: @yezz123

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b7cdcc1) 100.00% compared to head (1e835e5) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #86   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         8    +1     
  Lines          540       599   +59     
  Branches       138       152   +14     
=========================================
+ Hits           540       599   +59     
Files Changed Coverage Δ
pydantic_extra_types/color.py 100.00% <100.00%> (ø)
pydantic_extra_types/coordinate.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eumiro eumiro changed the title Remove useless int casting Refactor: use stdlib and remove useless code Aug 11, 2023
@yezz123
Copy link
Collaborator

yezz123 commented Aug 20, 2023

please review

Copy link
Collaborator

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@yezz123 yezz123 merged commit 7712714 into pydantic:main Aug 20, 2023
20 checks passed
@eumiro eumiro deleted the colors-refactor branch August 20, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants