Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new ConfigWrapper #5411

Merged
merged 5 commits into from
Apr 7, 2023
Merged

new ConfigWrapper #5411

merged 5 commits into from
Apr 7, 2023

Conversation

samuelcolvin
Copy link
Member

@samuelcolvin samuelcolvin commented Apr 7, 2023 •
edited
Loading

Fix #5353

Fix pydantic/pydantic-core#425 - slightly amazingly, thanks for @dmontagu for leaving such a helpful comment.

@samuelcolvin samuelcolvin marked this pull request as ready for review April 7, 2023 16:16
adriangb
adriangb approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

Makefile Show resolved Hide resolved
docs/usage/models.md Show resolved Hide resolved
pydantic/_internal/_config.py Show resolved Hide resolved
@samuelcolvin
Copy link
Member Author

@dmontagu merge when/if you're happy.

@dmontagu dmontagu merged commit 6ac397c into main Apr 7, 2023
@dmontagu dmontagu deleted the ConfigWrapper branch April 7, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

@dmontagu dmontagu dmontagu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Config machinery Config inheritance misbehavior?
3 participants
@samuelcolvin @adriangb @dmontagu