Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change link #461

Closed
jpdeleon opened this issue Jan 20, 2018 · 1 comment · Fixed by #463
Closed

change link #461

jpdeleon opened this issue Jan 20, 2018 · 1 comment · Fixed by #463

Comments

@jpdeleon
Copy link

pandas-datareader/pandas_datareader/google/daily.py

Line 47 in dcc09eb

return 'http://finance.google.com/finance/historical'

The line above should be changed to:
return 'https://finance.google.com/finance/historical'

to be able to download historical data.
bashtage added a commit to bashtage/pandas-datareader that referenced this issue Jan 20, 2018
@bashtage
BUG: Change google URLS
2212ab6 
Change Google finance urls

closes pydata#461
closes pydata#462
bashtage added a commit to bashtage/pandas-datareader that referenced this issue Jan 20, 2018
@bashtage
BUG: Change google URLS
5ffbe71 
Change Google finance urls

closes pydata#461
closes pydata#462
bashtage added a commit to bashtage/pandas-datareader that referenced this issue Jan 20, 2018
@bashtage
BUG: Change google URLS
bb54ebf 
Change Google finance urls

closes pydata#461
closes pydata#462
@bashtage bashtage mentioned this issue Jan 20, 2018
Merged
1 task
@bashtage
Copy link
Contributor

Both work but https is probably a better choice.

@rsvp rsvp mentioned this issue Jan 20, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New google urls bashtage/pandas-datareader
2 participants
@bashtage @jpdeleon