Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top of the sidebar gets hidden on small windows when scrolling #1493

Open
AlenkaF opened this issue Oct 4, 2023 · 5 comments
Open

Top of the sidebar gets hidden on small windows when scrolling #1493

AlenkaF opened this issue Oct 4, 2023 · 5 comments
Labels
kind: bug Something isn't working tag: CSS CSS and SCSS related issues tag: design Items related to design tasks or improvements

Comments

@AlenkaF
Copy link
Contributor

AlenkaF commented Oct 4, 2023

We have noticed that the top part of the primary and secondary sidebar menu gets hidden on small windows in case of the double header height.
When the header/navbar is not doubled in height, that doesn't happen.

Also the layout of the header elements in this case looks a bit random (version switcher, search box, icons, etc.).

I am sure this is not a trivial thing, but I still think it is worth checking.

Examples:

Beginning

Screenshot 2023-10-03 at 10 10 19

After scrolling just a bit:

Screenshot 2023-10-03 at 10 10 26

Arrow example

272190236-bdc30917-59e9-46cd-9539-7d5cc2c9c5ee

@12rambau
Copy link
Collaborator

12rambau commented Oct 4, 2023

the new search button is a lot wider and is breaking the display of the header navbar in lots of cases. It's on our radar but complicated. Any design idea is welcome !

@AlenkaF
Copy link
Contributor Author

AlenkaF commented Oct 4, 2023

Ah, I see!
Is it only the search button or the version switcher also?

I am brainstorming here (not knowing the code really, so this might be silly):
Is it possible to move the buttons to the top of the sidebar if/when the space is too little?

@12rambau
Copy link
Collaborator

12rambau commented Oct 4, 2023

both of them are free components so you can place them wherever you see fit.
On the other hand it's complicated to move them dynamically.

They are currently placed in the header navbar as this is the only one that is always available even on landing page (see #1092 to understand how this can become an issue)

@AlenkaF
Copy link
Contributor Author

AlenkaF commented Oct 4, 2023

Huh, that's a bummer. I will brainstorm with Joris, in case he has any ideas!

@jorisvandenbossche
Copy link
Member

While it would certainly be good to improve the layout so it happens less often that the items in the header get wrapped around causing the navbar of double height, but just to be clear: the actual root issue here is still a separate bug report. When it happens that the header is larger, it shouldn't cover the sidebar, I think?

@12rambau 12rambau added kind: bug Something isn't working tag: design Items related to design tasks or improvements tag: CSS CSS and SCSS related issues labels Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working tag: CSS CSS and SCSS related issues tag: design Items related to design tasks or improvements
Projects
None yet
Development

No branches or pull requests

3 participants