Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bd-article-container is not taking full width of its parent #904

Closed
bloussou opened this issue Aug 30, 2022 · 5 comments · Fixed by #964
Closed

bd-article-container is not taking full width of its parent #904

bloussou opened this issue Aug 30, 2022 · 5 comments · Fixed by #964
Assignees
Labels
kind: bug Something isn't working

Comments

@bloussou
Copy link

bloussou commented Aug 30, 2022

Hello,
Moving from 0.9.0 to 0.10.1 It looks like .bd-article-container as a max-width: 60em; set. It doesn't look great in my opinion:
image
In 0.9.0 .bd-article in.bd-content was taking full width with a much nicer result :
image

The change was introduced by this PR : 4b97fe0#diff-49f6c89aa34e046c7b8d0f3776503de95dd1befffe5f2e13d032c136264ec6cf

@choldgraf choldgraf added the kind: bug Something isn't working label Aug 30, 2022
@12rambau
Copy link
Collaborator

this started when we started implementing the ng-sphinx structure in the theme (#861). To be fair, I don't really understand why people want this fix 80-100 fix character per page and enforce it. I use huge screens at home, I'm simply never displaying anything full screen and I deal myself with the width I want to see ;-)
- me trying to fight a battle that I already lost millions of time -

On the other hand, I can confirm the bug from one of my documentation as well in pages autogenerated by automodule:

Capture d’écran 2022-08-30 à 19 42 31

@bloussou
Copy link
Author

bloussou commented Sep 1, 2022

Adding

html_sidebars = {
    "**": ["search-field.html", "sidebar-nav-bs.html"]
}

in my config.py and

.bd-article-container {
  width: 100%;
}

in my custom.css solve the issue.

@12rambau
Copy link
Collaborator

12rambau commented Sep 1, 2022

In your modification you are adding back some widgets in the left sidebar which is not necessary in my case.

  • I also think that this should be working without the need for extra CSS so let's keep it open for now

@choldgraf
Copy link
Collaborator

choldgraf commented Sep 7, 2022

I think this is a page in our documentation that shows this issue (not as pronounced because the content is wider but still there for debugging purposes):

https://pydata-sphinx-theme.readthedocs.io/en/stable/examples/subpages/subsubpages/index.html

I think the .bd-article-container rule shown above will fix this

re: limiting the word count per line, I don't have strong opinions other than we should follow best-practices that are generally recommended in industry / do what professional-looking documentation engines/sites do. I'm not a designer so I try to limit my personal design opinions in favor of what more well-resourced projects do 🤷

@StefRe
Copy link

StefRe commented Sep 22, 2022

@bloussou: applying this css change solves the issue for matplotlib (see matplotlib/matplotlib#23976) partially, but it creates a big white top margin:

current view:
grafik

with width: 100%;:
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants