add css class dropdown-item to version switcher #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @trallard, pinging you for possible review and reviewer suggestions |
drammock
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Is there some reason we weren't applying the dropdown-item class (per Bootstrap docs) to items in the version switcher dropdown?
an oversight, no good reason that I know of. This seems to work beautifully in the PR docs build. Thanks!! +1 for merge.
12rambau
approved these changes
Aug 16, 2023
trallard
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be the only thing needed to close #1358.
Is there some reason we weren't applying the
dropdown-itemclass (per Bootstrap docs) to items in the version switcher dropdown? This will automatically add the ability to select items in the dropdown using the arrow and enter keys.