Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version switcher dropdown not accessible #1358

Closed
drammock opened this issue Jun 20, 2023 · 2 comments · Fixed by #1411
Closed

version switcher dropdown not accessible #1358

drammock opened this issue Jun 20, 2023 · 2 comments · Fixed by #1411
Labels
kind: bug Something isn't working tag: accessibility Issues related to accessibility issues or efforts

Comments

@drammock
Copy link
Collaborator

drammock commented Jun 20, 2023

the version switcher does not conform to best practices for keyboard navigation / screen readers. Although it is possible to focus the switcher via tab-indexing, once focused it doesn't behave nicely (should allow arrow keys but only tabs work, visual focus highlighting inconsistent, etc)

@drammock drammock added kind: bug Something isn't working tag: accessibility Issues related to accessibility issues or efforts labels Jun 20, 2023
@trallard
Copy link
Collaborator

Adding more context from a previous review comment:

Also, I'd like to point out that the version selector component is not currently keyboard focusable and operable. I tried fixing / testing by setting tabindex="0" on the parent <div> with no success, so I will need to spend more time debugging/fixing this behaviour.

The desired behaviours would be as follows:

Collapsed select - menu button

  • TAB Focuses the selector button
  • Space / Enter opens the list and moves focus to the current option
  • Down and Up arrows expand the list

Expanded list

  • Up and Down arrows move through options, changing the highlighted option (do not change selection).
  • Space does nothing
  • Enter closes the menu, keeping the currently highlighted option selected
  • Escape closes the menu, keeping the currently highlighted option selected, and sets focus to the button

@trallard
Copy link
Collaborator

An up to date status of keyboard navigation can be found at #1357

cc/ @gabalafou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working tag: accessibility Issues related to accessibility issues or efforts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants