Modifications to enable sparse xarrays #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
==========================================
+ Coverage 97.28% 97.28% +<.01%
==========================================
Files 10 10
Lines 1620 1621 +1
==========================================
+ Hits 1576 1577 +1
Misses 44 44 |
3 tasks
|
Thanks, @nvictus! |
nvictus
added a commit
to nvictus/xarray
that referenced
this pull request
Aug 2, 2019
shoyer
pushed a commit
to pydata/xarray
that referenced
this pull request
Aug 5, 2019
) * Support for __array_function__ implementers * Pep8 * Consistent naming * Check for NEP18 enabled and nep18 non-numpy arrays * Replace .values with .data * Add initial test for nep18 * Fix linting issues * Add parameterized tests * Internal clean-up of isnull() to avoid relying on pandas This version should be much more compatible out of the box with duck typing. * Add sparse to ci requirements * Moar tests * Two more patches for __array_function__ duck-arrays * Don't use coords attribute from duck-arrays that aren't derived from DataWithCoords * Improve checking for coords, and autopep8 * Skip tests if NEP-18 envvar is not set * flake8 * Update xarray/core/dataarray.py Co-Authored-By: Stephan Hoyer <shoyer@gmail.com> * Fix coords parsing * More tests * Add align tests * Replace nep18 tests with more extensive tests on pydata/sparse * Add xfails for missing np.result_type (fixed by pydata/sparse/pull/261) * Fix xpasses * Revert isnull/notnull * Fix as_like_arrays by coercing dense arrays to COO if any sparse * Make Variable.load a no-op for non-dask duck arrays * Add additional method tests * Fix utils.as_scalar to handle duck arrays with ndim>0
shoyer
reviewed
Aug 6, 2019
| @@ -5,6 +5,8 @@ | |||
| eye, full, full_like, zeros, zeros_like, ones, ones_like, | |||
| kron, argwhere, isposinf, isneginf) | |||
|
|
|||
| from numpy.core._multiarray_umath import result_type | |||
There was a problem hiding this comment.
Beware, this is likely to break in a future NumPy release — this isn’t a public API
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I'm working on a SciPy sprint to get
sparsearrays intoxarray.With a couple tweaks to xarray anticipating objects implementing
__array_function__, I can get it to work with the following:Make
COO.astype()provide the copy argumentExpose result_type() though
sparseto bypass numpy's dispatcher -- I'm importing the lower level function.(I'm using numpy 1.16 with
'NUMPY_EXPERIMENTAL_ARRAY_FUNCTION'='1'Numpy 1.17.0rc1 currently fails due to an issue with numba numba/numba#4319)