Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Finch backend #678

Merged
merged 6 commits into from
May 17, 2024
Merged

Update Finch backend #678

merged 6 commits into from
May 17, 2024

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented May 15, 2024

Hi @hameerabbasi,

This PR updates Finch backend to the latest (unreleased yet) finch-tensor version.
I also enabled full Array API test suite, on my machine, with unreleased finch-tensor the result of running it is:

============================ 149 failed, 602 passed, 180 skipped, 225 warnings in 1365.91s (0:22:45) =============================

So about 60% of tests are passing.

@mtsokol mtsokol requested a review from hameerabbasi May 15, 2024 14:21
@mtsokol mtsokol self-assigned this May 15, 2024
Copy link

github-actions bot commented May 15, 2024

Test Results

5 923 tests  ±0   5 891 ✅  - 1   9m 23s ⏱️ +5s
    1 suites ±0      32 💤 +1 
    1 files   ±0       0 ❌ ±0 

Results for commit ee00601. ± Comparison against base commit 669d423.

This pull request skips 2 and un-skips 1 tests.
sparse.numba_backend.tests.test_compressed ‑ test_reductions_float16[i4-None-sum-kwargs0]
sparse.numba_backend.tests.test_coo ‑ test_reductions_float16[i4-None-sum-kwargs0]
sparse.numba_backend.tests.test_coo ‑ test_reductions_float16[f8-None-sum-kwargs0]

♻️ This comment has been updated with latest results.

hameerabbasi
hameerabbasi previously approved these changes May 17, 2024
@mtsokol mtsokol requested a review from hameerabbasi May 17, 2024 13:51
@mtsokol mtsokol requested a review from hameerabbasi May 17, 2024 14:00
@mtsokol mtsokol merged commit 554cc7b into main May 17, 2024
13 checks passed
@mtsokol mtsokol deleted the finch-tensor-update branch May 17, 2024 14:05
@mtsokol mtsokol mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants