Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bool weights #4075

Merged
merged 6 commits into from
May 23, 2020
Merged

Fix bool weights #4075

merged 6 commits into from
May 23, 2020

Conversation

mathause
Copy link
Collaborator

mathause
mathause commented May 18, 2020
View reviewed changes
doc/whats-new.rst Outdated Show resolved Hide resolved
xarray/core/weighted.py Outdated Show resolved Hide resolved
@mathause mathause mentioned this pull request May 18, 2020
Closed
23 tasks
@max-sixty
Copy link
Collaborator

Thanks @mathause ! LGTM

@max-sixty
Copy link
Collaborator

(small merge conflict fixed; merge or ping or green)

@mathause
Copy link
Collaborator Author

Thanks @max-sixty ready to merge

@max-sixty
Copy link
Collaborator

Thanks a lot @mathause !

@max-sixty max-sixty merged commit f3ffab7 into pydata:master May 23, 2020
dcherian added a commit to dcherian/xarray that referenced this pull request May 25, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into fix-sparse
c9a4205 
* upstream/master:
  Improve interp performance (pydata#4069)
  Auto chunk (pydata#4064)
  xr.cov() and xr.corr() (pydata#4089)
  allow multiindex levels in plots (pydata#3938)
  Fix bool weights (pydata#4075)
  fix dangerous default arguments (pydata#4006)
@mathause mathause deleted the fix/bool_weights branch August 19, 2020 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] when passing boolean weights to weighted mean
2 participants
@mathause @max-sixty