Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the RTD timeouts #4254

Merged
merged 3 commits into from
Jul 22, 2020
Merged

fix the RTD timeouts #4254

merged 3 commits into from
Jul 22, 2020

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jul 22, 2020

This attempts to fix the RTD timeouts. I think these are due to a warning from matplotlib, which we can probably just ignore for now.

  • attempts to close RTD PR builds are timing out #4249
  • Tests added
  • Passes isort . && black . && mypy . && flake8
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

@keewis
Copy link
Collaborator Author

keewis commented Jul 22, 2020

okay, so with this my own setup passes, but the PR build seems to have had a hiccup (it's still running, though).

We need to remember to revert this PR once pandas-dev/pandas#35361 has been merged and a new pandas was released.

@keewis
Copy link
Collaborator Author

keewis commented Jul 22, 2020

that seems to have worked, too, so this should be ready for merging.

@dcherian
Copy link
Contributor

Thanks @keewis

@dcherian dcherian merged commit a081d01 into pydata:master Jul 22, 2020
@keewis keewis deleted the fix-rtd branch July 22, 2020 21:18
@TomAugspurger
Copy link
Contributor

FYI pandas-dev/pandas#35393 is the PR to follow. It'll be included in pandas 1.1.0, which should be out in a week or so.

@max-sixty
Copy link
Collaborator

Thanks @keewis !

dcherian added a commit to jacobtomlinson/xarray that referenced this pull request Jul 24, 2020
* upstream/master:
  Added xarrays-spatial and updated geoviews link (pydata#4262)
  update docs to point to xarray-contrib and xarray-tutorial (pydata#4252)
  Add release summary, some touch-ups (pydata#4217)
  CFTimeIndex calendar in repr (pydata#4092)
  fix the RTD timeouts (pydata#4254)
  update isort CI and pre-commit hook (pydata#4204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTD PR builds are timing out
4 participants