WIP: Ensure that zarr.ZipStores are closed #4395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmaarrfk
force-pushed
the
close_zip_store_datasets
branch
from
fed1b37
to
bbd2515
Compare
hmaarrfk
changed the title
|
I'm not too sure about this anymore. with the way the test is written now, it is unclear to me if the store should be closed afterward. I'm also unsure of how to deal with the case where the user passed it a ZipStore instead of a string. Will have to keep thinking. |
|
@hmaarrfk - wondering what your current thoughts on this issue are? Perhaps this can be handled better upstream in zarr-python? Should we close this? |
|
I'm not sure. I decided not to use zarr (not now) so i lost interest sorry. |
|
Ultimately, I'm not sure how you want to manage resources. This zarr store could be considered a resource and thus, may have an owner. Or maybe zarr should close itself upon garbage cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZipStores aren't always closed making it hard to use them as fluidly as regular zarr stores.
isort . && black . && mypy . && flake8# master doesn't pass blackwhats-new.rstapi.rst