Remove npcompat.moveaxis

[Illviljan]

Remove some compatibility code that doesn't seem necessary anymore.

• Passes pre-commit run --all-files

[pep8speaks]

Hello @Illviljan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-20 20:31:33 UTC

[max-sixty]

It's probably worth double-checking that the more complex Variable __getitem__ methods are also tested on Dask arrays. We could you an approach like #5350 if we're not confident.

[Illviljan]

It's probably worth double-checking that the more complex Variable __getitem__ methods are also tested on Dask arrays. We could you an approach like #5350 if we're not confident.

I don't understand how this works, @max-sixty. You're adding the variable da to the method but where does da then later come from? It doesn't seem to be defined in this file?

The numpy implementation seems very similar to the npcompat version:
https://github.com/numpy/numpy/blob/fb215c76967739268de71aa4bda55dd1b062bc2e/numpy/core/numeric.py#L1405

Maybe the npcompat code was copy/pasted just to avoid waiting on numpy releases?

[max-sixty]

Yes, pytest can be a bit confusing at first, but it's a really nice framework — da comes from https://github.com/pydata/xarray/blob/v0.18.2/xarray/tests/test_dataarray.py#L6458, which is parametrized with both a numpy-backed and a dask-backed array, so it creates two tests.

I agree this seems like it should be fine, and maybe I'm being a bit too cautious. @keewis could you give this a check given my track-record is blotchy now, and we can merge if you agree?

[keewis]

this does look good to me, but I'm somewhat confused about one of the comments that were removed.

[keewis]

I'm not sure how to read this comment (added in #3084): does this mean that we still need this, even if __array_function__ is always on? @shoyer, would you be able to explain?

[max-sixty]

@shoyer if you get a moment, could you take a glance at this and see if it looks OK, or we should add more tests?

[dcherian]

Thanks @Illviljan !