Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ds.dims returning dict #8500

Merged
merged 26 commits into from
Dec 6, 2023
Merged

Deprecate ds.dims returning dict #8500

merged 26 commits into from
Dec 6, 2023

Commits on Dec 1, 2023

  1. raise FutureWarning

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    19708fa View commit details
    Browse the repository at this point in the history

  2. change some internal instances of ds.dims -> ds.sizes

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    9747fe7 View commit details
    Browse the repository at this point in the history

  3. improve clarity of which unexpected errors were raised

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    0362233 View commit details
    Browse the repository at this point in the history

  4. whatsnew

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    99d7e16 View commit details
    Browse the repository at this point in the history

  5. return a class which warns if treated like a Mapping

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    3e05777 View commit details
    Browse the repository at this point in the history

  6. fix failing tests

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    5a22dca View commit details
    Browse the repository at this point in the history

  7. avoid some warnings in the docs

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    72eb62d View commit details
    Browse the repository at this point in the history

  8. silence warning caused by pydata#8491

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    e911155 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into deprecate_ds_dims_returning_dict

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    382601f View commit details
    Browse the repository at this point in the history

  10. fix another warning

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    2c9cb7d View commit details
    Browse the repository at this point in the history

  11. typing of .get

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    d862f89 View commit details
    Browse the repository at this point in the history

  12. fix various uses of ds.dims in tests

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    225414c View commit details
    Browse the repository at this point in the history

  13. fix some warnings

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    3391c83 View commit details
    Browse the repository at this point in the history

  14. add test that FutureWarnings are correctly raised

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    93f8caa View commit details
    Browse the repository at this point in the history

  15. more fixes to avoid warnings

    @TomNicholas
    TomNicholas committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    c0aa491 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. update tests to avoid warnings

    @TomNicholas
    TomNicholas committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    e4d45ac View commit details
    Browse the repository at this point in the history

  2. yet more fixes to avoid warnings

    @TomNicholas
    TomNicholas committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    abc4a20 View commit details
    Browse the repository at this point in the history

  3. also warn in groupby.dims

    @TomNicholas
    TomNicholas committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    ef11e77 View commit details
    Browse the repository at this point in the history

  4. change groupby tests to match

    @TomNicholas
    TomNicholas committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    965673b View commit details
    Browse the repository at this point in the history

  5. update whatsnew to include groupby deprecation

    @TomNicholas
    TomNicholas committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    27f7642 View commit details
    Browse the repository at this point in the history

  6. filter warning when we actually test ds.dims

    @TomNicholas
    TomNicholas committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    3406cc7 View commit details
    Browse the repository at this point in the history

  7. remove error I used for debugging

    @TomNicholas
    TomNicholas committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    726f390 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into deprecate_ds_dims_returning_dict

    @TomNicholas
    TomNicholas authored Dec 2, 2023
    Configuration menu
    Copy the full SHA
    d1209ea View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. Merge branch 'main' into deprecate_ds_dims_returning_dict

    @TomNicholas
    TomNicholas authored Dec 3, 2023
    Configuration menu
    Copy the full SHA
    0b6466e View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Merge branch 'main' into deprecate_ds_dims_returning_dict

    @TomNicholas
    TomNicholas authored Dec 5, 2023
    Configuration menu
    Copy the full SHA
    b473d24 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Merge branch 'main' into deprecate_ds_dims_returning_dict

    @dcherian
    dcherian authored Dec 6, 2023
    Configuration menu
    Copy the full SHA
    ddbab72 View commit details
    Browse the repository at this point in the history