Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the list -s command when result_dep is used. #44

Closed
wants to merge 2 commits into from
Closed

Fix the list -s command when result_dep is used. #44

wants to merge 2 commits into from

Conversation

saimn
Copy link
Contributor

@saimn saimn commented Mar 31, 2015

The tasks dict was not passed to get_status when using doit list --all -s mytask

Traceback (most recent call last):
  File "/home/conseil/lib/doit/doit/doit_cmd.py", line 175, in run
    return command.parse_execute(args)
  File "/home/conseil/lib/doit/doit/cmd_base.py", line 111, in parse_execute
    return self.execute(params, args)
  File "/home/conseil/lib/doit/doit/cmd_base.py", line 352, in execute
    return self._execute(**exec_params)
  File "/home/conseil/lib/doit/doit/cmd_list.py", line 149, in _execute
    self._print_task(template, task, status, list_deps)
  File "/home/conseil/lib/doit/doit/cmd_list.py", line 80, in _print_task
    task_status = self.dep_manager.get_status(task, None)
  File "/home/conseil/lib/doit/doit/dependency.py", line 576, in get_status
    uptodate_result = utd(*args, **utd_kwargs)
  File "/home/conseil/lib/doit/doit/task.py", line 537, in __call__
    dep_task = self.tasks_dict[self.dep_name]
TypeError: 'NoneType' object has no attribute '__getitem__'

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 99.76% when pulling 8edb5b3 on saimn:list-result-dep into 0ebdfa3 on pydoit:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) to 99.76% when pulling fd4ae8f on saimn:list-result-dep into 0ebdfa3 on pydoit:master.

@schettino72
Copy link
Member

Thanks. This is merged now.

I did not use your tests because I dont want to let "sample_tasks" grow more since it affects many tests. It is ok to use only on very basic tests...

@schettino72 schettino72 closed this Apr 1, 2015
@schettino72 schettino72 added this to the 0.28 milestone Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants