Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custody tracking incorrect for UnpackArchiveStep #67

Closed
pydsigner opened this issue Nov 19, 2023 · 0 comments · Fixed by #69
Closed

Custody tracking incorrect for UnpackArchiveStep #67

pydsigner opened this issue Nov 19, 2023 · 0 comments · Fixed by #69
Assignees
@pydsigner
Labels
bug Something isn't working
Milestone
1.0.0

Comments

@pydsigner
Copy link
Owner

#61 worked around the issue identified in #60, but actually broke the staleness checker for UnpackArchiveStep, causing it to always get unpacked with this message:

Missing upstream record (examples\code_index\code.zip)...

We will need to revert #61 and pursue a proper fix for #66 instead.
@pydsigner pydsigner added the bug Something isn't working label Nov 19, 2023
@pydsigner pydsigner added this to the 1.0.0 milestone Nov 19, 2023
@pydsigner pydsigner self-assigned this Nov 19, 2023
pydsigner added a commit that referenced this issue Nov 19, 2023
@pydsigner
Revert "Don't include target directory in archive unpack custody outp…
73a7f00 
…uts (#60)" (#67)

This reverts commit 7eec17f.
@pydsigner pydsigner linked a pull request Nov 19, 2023 that will close this issue
Revert incorrect fix for UnpackArchiveStep custody information that broke staleness checks (#67) #69
Merged
pydsigner added a commit that referenced this issue Nov 19, 2023
@pydsigner
Merge pull request #69 from pydsigner/GH-67_archive_custody_fix
95da723 
Revert incorrect fix for UnpackArchiveStep custody information that broke staleness checks (#67)
@pydsigner pydsigner mentioned this issue Nov 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pydsigner pydsigner

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0
1 participant
@pydsigner