Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend Current Fit's Ship and Name to the Window's Title #2601

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Nucanot
Copy link

@Nucanot Nucanot commented Mar 29, 2024

When you have multiple fits open, the names of the fits in the tabs get truncated and it's hard to tell which fit is which (especially when looking at different variations of the same fit).

This PR solves the issue by adding extra information to the window's title—the ship and the fit name.

Format is <ship name> "<fit name>" — <default title>
<default title> is the title, either "pyfa" or "pyfa v1.2.3 - Python Fitting Assistant"

The title is update when the active fit changes (via the tab switcher) or the current fit is renamed.

This commit prepends the current fit's ship name and fit name to the main frame's title.

Format is <ship name> "<fit name>" — <default title>

<default title> is the title, either "pyfa" or "pyfa v1.2.3 - Python Fitting Assistant"

The title is update when the active fit changes (via the tab switcher) or the current fit is renamed.
@DarkFenX
Copy link
Member

DarkFenX commented Apr 16, 2024

Thanks. I will try to include it for next release (don't have time for the today's one, sorry).

Although there might be side effects, I know on some OS' there is a notification when window title changes (think it was default gnome desktop? might want to test it there to see if it's causing any issues or not)

@Nucanot
Copy link
Author

Nucanot commented May 13, 2024

Thanks. I will try to include it for next release (don't have time for the today's one, sorry).

Although there might be side effects, I know on some OS' there is a notification when window title changes (think it was default gnome desktop? might want to test it there to see if it's causing any issues or not)

I've only tested on macOS. I will try to spin up a Linux VM when I have time and test there.

I would be surprised if the GNOME window manager fires notifications on title change though (haven't seen this when I was using Linux before).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants