all: use yield from #1537
Merged
all: use yield from #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anteru
reviewed
Sep 6, 2020
Anteru
reviewed
Sep 6, 2020
Anteru
reviewed
Sep 6, 2020
| def get_tokens_unprocessed(self, text): | ||
| for index, token, value in \ | ||
| RegexLexer.get_tokens_unprocessed(self, text): | ||
| yield index, token, value |
There was a problem hiding this comment.
Why was this removed wholesale? I presume because that's equivalent to the parent class implementation?
There was a problem hiding this comment.
Since the parent class is RegexLexer, AFAICS it just delegates everything to it.
Anteru
approved these changes
Sep 6, 2020
Anteru
added
the
changelog-update
Anteru
removed
the
changelog-update
Merged
Kenny2github
pushed a commit
to Kenny2github/pygments
that referenced
this pull request
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.