-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix torch.mean(auc) and updating model init in utils.py #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
print function throws list error, expects float tensor
DOMINANT, CONAD, GAAN argument "alpha" replace to "weight"
ParthaPratimBanik
changed the title
fix torch.mean(auc)
fix torch.mean(auc) and updating model init in utils.py
Aug 16, 2023
Pull Request Test Coverage Report for Build 5890522716
💛 - Coveralls |
kayzliu
requested changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. It's over all looks good. But several minor things need to be changed.
`wight` to `weight`
Because at the end of for loop, all types of lists will be converted to tensor type.
kayzliu
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #85
torch.mean()
,toch.std()
, andtorch.max()
should be a tensor float type instead of list.eval_recall_at_k()
return tensor float type value, it must convert to list type float value to append into therec
list.Fixed issue Inconsistency with BOND paper #83
weight
.DOMINANT
,GAAN
, andCONAD
) fromalpha
toweight
.Issues #83, #85, and the above solutions are tested on torch 2.0.1+cu117.