Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix torch.mean(auc) and updating model init in utils.py #86

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

ParthaPratimBanik
Copy link
Contributor

@ParthaPratimBanik ParthaPratimBanik commented Aug 16, 2023

Fixed issue #85

  • The argument of torch.mean(), toch.std(), and torch.max() should be a tensor float type instead of list.
  • eval_recall_at_k() return tensor float type value, it must convert to list type float value to append into the rec list.


    Fixed issue Inconsistency with BOND paper #83
  • Remove heuristic selection of weight.
  • Update the parameter name for detectors (DOMINANT, GAAN, and CONAD) from alpha to weight.

Issues #83, #85, and the above solutions are tested on torch 2.0.1+cu117.

print function throws list error, expects float tensor
DOMINANT, CONAD, GAAN argument "alpha" replace to "weight"
@ParthaPratimBanik ParthaPratimBanik changed the title fix torch.mean(auc) fix torch.mean(auc) and updating model init in utils.py Aug 16, 2023
@coveralls
Copy link

coveralls commented Aug 17, 2023

Pull Request Test Coverage Report for Build 5890522716

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.562%

Totals Coverage Status
Change from base Build 5709379320: 0.0%
Covered Lines: 2503
Relevant Lines: 2514

💛 - Coveralls

Copy link
Member

@kayzliu kayzliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. It's over all looks good. But several minor things need to be changed.

benchmark/utils.py Outdated Show resolved Hide resolved
benchmark/main.py Show resolved Hide resolved
`wight` to `weight`
Because at the end of for loop, all types of lists will be converted to tensor type.
Copy link
Member

@kayzliu kayzliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kayzliu kayzliu merged commit 2508cd1 into pygod-team:main Aug 17, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants