Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pyproj imports in CGrid_geo #51

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Fix pyproj imports in CGrid_geo #51

merged 1 commit into from
Sep 11, 2019

Conversation

stefraynaud
Copy link

This simple PR solves #49

@coveralls
Copy link

Pull Request Test Coverage Report for Build 366

  • 1 of 5 (20.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 85.868%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pygridgen/grid.py 1 5 20.0%
Totals Coverage Status
Change from base Build 364: -0.2%
Covered Lines: 638
Relevant Lines: 743
💛 - Coveralls

@phobson
Copy link
Collaborator

phobson commented May 3, 2019

Thanks for the PR @stefraynaud !

Any chance you have time to write a quick test that confirms that the class works?

I think creating a CGrid_geo object and confirming that the x and y attributes are computed would suffice.

@phobson phobson mentioned this pull request Sep 11, 2019
Closed
@phobson phobson merged commit d7101e7 into pygridgen:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefraynaud @coveralls @phobson