Change 'ini_file_name' and 'log_file_name' to accept str, bytes, or None #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been issued in #290
For python users, it feels more natural to use strings to manage config and log filenames instead of
bytes
. I thus changed the interface ofini_file_name
andlog_file_name
to acceptstr
andNone
. It is now possible to write:I kept the option of passing a
bytes
for backward compatibilities; this still works:I also changed the return type of the getter to be an
str
instead of abytes
. This is unfortunately not backward compatible but feels more python friendly, and I don't think this is a feature that was intensively used.