Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook for patoolib #748

Merged
merged 4 commits into from
May 22, 2024
Merged

Add hook for patoolib #748

merged 4 commits into from
May 22, 2024

Conversation

mtayeldev
Copy link
Contributor

test run here: https://github.com/mtayeldev/pyinstaller-hooks-contrib/actions/runs/9180607046 (for some reason it fails for unrelated test cases)

original issue: pyinstaller/pyinstaller#3013

@rokm
Copy link
Member

rokm commented May 21, 2024

Errors on python >= 3.10 should be fixed with pyinstaller/pyinstaller#8555.

rokm added 2 commits May 22, 2024 00:31
Extend the patoolib test with implementation that triggers import
of module from `patoolib.programs`, and demonstrates the need for
collecting modules from that sub-package.
@rokm rokm merged commit 500bdf2 into pyinstaller:master May 22, 2024
14 checks passed
@rokm
Copy link
Member

rokm commented May 22, 2024

Thanks @mtayeldev !

@mtayeldev
Copy link
Contributor Author

Dear @rokm,

Thank you actually, you contributed more to the PR than I did, and it would have taken me weeks to get enough time and get educated enough to finish it

@mtayeldev mtayeldev deleted the mt/hook-for-patoolib branch May 23, 2024 19:05
github-actions bot pushed a commit to wxx9248/Pickle-Rush that referenced this pull request Jun 10, 2024
…4.7 (#103)

Bumps
[pyinstaller-hooks-contrib](https://github.com/pyinstaller/pyinstaller-hooks-contrib)
from 2024.6 to 2024.7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/releases">pyinstaller-hooks-contrib's
releases</a>.</em></p>
<blockquote>
<h2>2024.7</h2>
<p>Please see the <a
href="https://www.github.com/pyinstaller/pyinstaller-hooks-contrib/tree/master/CHANGELOG.rst">changelog</a>
for more details</p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/blob/master/CHANGELOG.rst">pyinstaller-hooks-contrib's
changelog</a>.</em></p>
<blockquote>
<h2>2024.7 (2024-06-08)</h2>
<p>New hooks</p>
<pre><code>
* Add hook for ``dbus_fast`` in order to collect submodules that are
imported
from cythonized extensions.
(`[#600](pyinstaller/pyinstaller-hooks-contrib#600)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/600&gt;`_)
* Add hook for ``gribapi`` package from ``eccodes`` dist, in order to
  collect bundled headers and ensure that the eccodes shared library is
collected from the build environment.
(`[#744](pyinstaller/pyinstaller-hooks-contrib#744)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/744&gt;`_)
* Add hook for ``patoolib`` to collect dynamically-imported modules from
the ``patoolib.programs`` sub-package.
(`[#748](pyinstaller/pyinstaller-hooks-contrib#748)

&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/748&gt;`_)
<p>Updated hooks
</code></pre></p>
<ul>
<li>Extend the <code>xarray</code> hook to collect additional backend
plugins that are
registered via the <code>xarray.backends</code> entry-point (e.g.,
<code>cfgrib</code>).
(<code>[#744](pyinstaller/pyinstaller-hooks-contrib#744)
&lt;https://github.com/pyinstaller/pyinstaller-hooks-contrib/issues/744&gt;</code>_)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/7c8ef4785fc5bebbcf740d47c7468af30fba793f"><code>7c8ef47</code></a>
Release v2024.7</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/60f867bd84639df3a9354930361d84c0396c62a8"><code>60f867b</code></a>
Scheduled weekly dependency update for week 22 (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/751">#751</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/53e719c645e9518f5e337f8ffc818ef9bda9b1a7"><code>53e719c</code></a>
Assorted licence cleanups</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/19cb5edfd9de53338ea1bf532c2b8ca6385921fd"><code>19cb5ed</code></a>
Scheduled weekly dependency update for week 21 (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/750">#750</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/500bdf255c6f4f776b7beead5d006cf82041472c"><code>500bdf2</code></a>
Add hook for patoolib (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/748">#748</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/6fc0361d478df48f8f1f3784197d6c833721bc5e"><code>6fc0361</code></a>
ci: use macos-12 and ubuntu-22.04 instead of -latest</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/1680e20dd046a335414d8e94b1121201da9a56ca"><code>1680e20</code></a>
Scheduled weekly dependency update for week 20 (<a
href="https://redirect.github.com/pyinstaller/pyinstaller-hooks-contrib/issues/747">#747</a>)</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/c9c2a328ba29ce56d4b9191521216c33c3dd76e5"><code>c9c2a32</code></a>
hooks: add hook for dbus_fast</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/80908c74fa52f808f6b928bd9718f133ea71e479"><code>80908c7</code></a>
ci: pr-test: fix compatibility with Apple/FreeBSD diff</li>
<li><a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/commit/a2a1af5e6ade258878d9a0891d0ba90b450852c4"><code>a2a1af5</code></a>
hook: add hook for gribapi package from eccodes dist</li>
<li>Additional commits viewable in <a
href="https://github.com/pyinstaller/pyinstaller-hooks-contrib/compare/2024.6...2024.7">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pyinstaller-hooks-contrib&package-manager=pip&previous-version=2024.6&new-version=2024.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants