Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ryvencore and drop 3.11 support #206

Closed
wants to merge 6 commits into from
Closed

Pin ryvencore and drop 3.11 support #206

wants to merge 6 commits into from

Conversation

liamhuber
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Binder 👈 Launch a binder notebook on branch pyiron/ironflow/pin_versions

@liamhuber
Copy link
Member Author

======================================================================
ERROR: test_gui (unittest.loader._FailedTest.test_gui)
----------------------------------------------------------------------
ImportError: Failed to import test module: test_gui
Traceback (most recent call last):
  File "/usr/share/miniconda3/envs/my-env/lib/python3.11/unittest/loader.py", line 419, in _find_test_path
    module = self._get_module_from_name(name)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/share/miniconda3/envs/my-env/lib/python3.11/unittest/loader.py", line 362, in _get_module_from_name
    __import__(name)
  File "/home/runner/work/ironflow/ironflow/tests/unit/test_gui.py", line 6, in <module>
    from ironflow.gui.gui import GUI
  File "/home/runner/work/ironflow/ironflow/ironflow/gui/gui.py", line 14, in <module>
    from ironflow.gui.browser import BrowserGUI
  File "/home/runner/work/ironflow/ironflow/ironflow/gui/browser.py", line 12, in <module>
    from pyiron_atomistics import Project
  File "/usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/pyiron_atomistics/__init__.py", line 4, in <module>
    from pyiron_atomistics.project import Project
  File "/usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/pyiron_atomistics/project.py", line 34, in <module>
    from pyiron_atomistics.atomistics.structure.factory import StructureFactory
  File "/usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/pyiron_atomistics/atomistics/structure/factory.py", line 40, in <module>
    from pyiron_atomistics.atomistics.structure.factories.materialsproject import (
  File "/usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/pyiron_atomistics/atomistics/structure/factories/materialsproject.py", line 2, in <module>
    from mp_api.client import MPRester
  File "/usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/mp_api/client/__init__.py", line 7, in <module>
    from .core import MPRestError
  File "/usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/mp_api/client/core/__init__.py", line 3, in <module>
    from .client import BaseRester, MPRestError
  File "/usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/mp_api/client/core/client.py", line 31, in <module>
    from mp_api.client.core.utils import api_sanitize, validate_ids
  File "/usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/mp_api/client/core/utils.py", line 7, in <module>
    from maggma.utils import get_flat_models_from_model
ImportError: cannot import name 'get_flat_models_from_model' from 'maggma.utils' (/usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/maggma/utils.py)

Smells like upstream dependency problems again. How is it that pyiron_atomistics is passing but everywhere I depend on it I am getting maggma errors?

@liamhuber
Copy link
Member Author

I was getting the same problem over on pyiron_workflow. mp-api doesn't pin its maggma dependence (also not in the conda-forge feedstock), and somehow an old version is getting installed that has a different API than mp-api expects. Over on workflow, I thought this might be a cross-conflict with pympipool, so I got rid of that dependency and then it all worked fine. But maybe there is instead just some caching issue? Let's try wiping the caches here and re-running.

@liamhuber
Copy link
Member Author

Nope, wasn't the cache. A truly ancient version of maggma is getting installed: maggma 0.38.1 . I have no idea why.

liamhuber and others added 3 commits October 5, 2023 14:40
To try to smoke out who dragging down the install (it's not pinned upstream in mp-api and should be)
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Pull Request Test Coverage Report for Build 6424816882

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.828%

Totals Coverage Status
Change from base Build 5753854100: 0.0%
Covered Lines: 1873
Relevant Lines: 3685

💛 - Coveralls

@liamhuber
Copy link
Member Author

Ok, just pinning maggma worked. I have no idea why I got an outdated version to begin with then.

@liamhuber
Copy link
Member Author

pyiron / unit-tests (windows-latest, 3.11, win-64-py-3-10, C:\Miniconda3\envs\my-env):

Could not solve for environment specs
The following package could not be installed
└─ pyiron_ontology 0.1.3  is installable and it requires
   └─ owlready2   with the potential options
      ├─ owlready2 [0.20|0.21|...|0.26] would require
      │  └─ python >=3.6,<3.7.0a0 , which can be installed;
      ├─ owlready2 [0.20|0.21|...|0.39] would require
      │  └─ python >=3.7,<3.8.0a0 , which can be installed;
      ├─ owlready2 [0.22|0.23|...|0.39] would require
      │  └─ python >=3.8,<3.9.0a0 , which can be installed;
      ├─ owlready2 [0.24|0.25|...|0.39] would require
      │  └─ python >=3.9,<3.10.0a0 , which can be installed;
      └─ owlready2 [0.35|0.36|0.37|0.38|0.39] would require
         └─ python >=3.10,<3.11.0a0 , which can be installed.
Error: Process completed with exit code 1.

Yup, great, there have been no updates to owlready2 for windows since almost a year ago.

Also the matrix label on the centralized CI needs to be updated.

@liamhuber liamhuber changed the title Pin ryvencore Pin ryvencore and drop 3.11 support Oct 5, 2023
To stay cross platform. pyiron_ontology -> owlready2 stopped supporting new versions for windows.
@jan-janssen
Copy link
Member

As mentioned in pyiron/pyiron_ontology#26 I updated the owlready2 package on conda-forge. So there is no need to drop support for Python 3.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants