Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

job.server: remove to_hdf() and from_hdf() #1380

Merged
merged 8 commits into from
Mar 26, 2024
Merged

job.server: remove to_hdf() and from_hdf() #1380

merged 8 commits into from
Mar 26, 2024

Conversation

jan-janssen
Copy link
Member

The to_hdf() and from_hdf() function are replaced by the to_dict() and from_dict() function.

@jan-janssen
job.server: remove to_hdf() and from_hdf()
8f86d32 
The to_hdf() and from_hdf() function are replaced by the to_dict() and from_dict() function.
@jan-janssen
fix tests
3db8e62
@jan-janssen
Copy link
Member Author

The run_job_with_runmode_queue(job) in runfunction.py still requires the to_hdf() from the job.server object:
https://github.com/pyiron/pyiron_base/blob/main/pyiron_base/jobs/job/runfunction.py#L412
This was not included in the tests, as it only appears in interaction with queuing systems.

@jan-janssen jan-janssen marked this pull request as draft March 16, 2024 23:56
@jan-janssen jan-janssen marked this pull request as ready for review March 17, 2024 00:10
@jan-janssen jan-janssen added the format_black reformat the code using the black standard label Mar 17, 2024
@jan-janssen jan-janssen mentioned this pull request Mar 17, 2024
Merged
@jan-janssen jan-janssen mentioned this pull request Mar 19, 2024
Merged
@jan-janssen jan-janssen mentioned this pull request Mar 26, 2024
Closed
@jan-janssen jan-janssen merged commit 0c6686f into main Mar 26, 2024
24 of 25 checks passed
@jan-janssen jan-janssen deleted the server_remove_hdf branch March 26, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrv pmrv pmrv left review comments

Assignees
No one assigned
Labels
format_black reformat the code using the black standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jan-janssen @pmrv @pyiron-runner