Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project move for cli #1442

Merged
merged 2 commits into from
May 23, 2024
Merged

project move for cli #1442

merged 2 commits into from
May 23, 2024

Conversation

XzzX
Copy link
Contributor

@XzzX XzzX commented May 23, 2024

No description provided.

@jan-janssen
Copy link
Member

The registration in control.py seems to be missing.

@jan-janssen jan-janssen requested a review from pmrv May 23, 2024 11:51
@pmrv
Copy link
Contributor

pmrv commented May 23, 2024

The registration in control.py seems to be missing.

Correct otherwise lgtm.

jan-janssen
jan-janssen approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is ready to be merged.

@jan-janssen jan-janssen merged commit b901850 into pyiron:main May 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

@pmrv pmrv Awaiting requested review from pmrv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XzzX @jan-janssen @pmrv