Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] use retry from pyiron_snippets #1456

Merged
merged 11 commits into from
Jun 3, 2024
Merged

[patch] use retry from pyiron_snippets #1456

merged 11 commits into from
Jun 3, 2024

Conversation

liamhuber
Copy link
Member

No description provided.

@liamhuber
Copy link
Member Author 

File "/usr/share/miniconda3/envs/my-env/lib/python3.9/site-packages/pyiron_snippets/retry.py", line 20, in <module>
          log: bool | object = True,
      TypeError: unsupported operand type(s) for |: 'type' and 'type'
      [end of output]

Naively this looks like retry is not 3.9 compatible, but the test runs fine on 3.9 over on the snippets repo, so I'm going to dig a bit deeper.

@liamhuber
Copy link
Member Author

I think somehow the test on the snippets repo must have access to from __future__ import annotations while it doesn't here. I'll add it explicitly and patch snippets.

@liamhuber
Bump snippets dependency
6273877 
It's not available yet, but the next patch will import annotations from future for retry.
@liamhuber
Copy link
Member Author

Ok, this is just waiting on pyiron_snippets-0.1.1 being live.

@liamhuber liamhuber marked this pull request as ready for review June 1, 2024 15:06
Base automatically changed from snippets_alarm to main June 3, 2024 18:33
jan-janssen
jan-janssen reviewed Jun 3, 2024
View reviewed changes
pyiron_base/__init__.py Outdated Show resolved Hide resolved
@liamhuber
Copy link
Member Author

Import alarm should not be showing up in the diff here -- something needs to be merged in or the target needs to be changed

@jan-janssen
Merge remote-tracking branch 'refs/remotes/origin/main' into snippets…
9328714 
…_retry

# Conflicts:
#	pyiron_base/utils/error.py
@jan-janssen jan-janssen merged commit 292e1c3 into main Jun 3, 2024
24 of 25 checks passed
@jan-janssen jan-janssen deleted the snippets_retry branch June 3, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamhuber @jan-janssen