Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executable: Set environment variables for subprocess #1485

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Executable: Set environment variables for subprocess #1485

merged 5 commits into from
Jun 20, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Jun 18, 2024 •
edited
Loading

Set the environment variables PYIRON_CORES, PYIRON_THREADS and PYIRON_GPUS when pyiron_base calls an external executable. Only set these variables for the subprocess.

@jan-janssen jan-janssen requested a review from pmrv June 18, 2024 16:19
@jan-janssen jan-janssen marked this pull request as draft June 18, 2024 17:41
@jan-janssen jan-janssen reopened this Jun 18, 2024
@jan-janssen jan-janssen mentioned this pull request Jun 18, 2024
Closed
@jan-janssen jan-janssen marked this pull request as ready for review June 19, 2024 13:59
pmrv
pmrv approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@pmrv pmrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jan-janssen jan-janssen merged commit 09aeb7c into main Jun 20, 2024
31 of 42 checks passed
@jan-janssen jan-janssen deleted the subprocess_env branch June 20, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrv pmrv pmrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-janssen @pmrv