Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PythonFunctionContainerJob: Use calculate() function #1505

Closed
wants to merge 10 commits into from

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Jul 2, 2024

Rather than having a custom run_static() function for the PythonFunctionContainerJob, it now implements the get_calculate_function() function and the calculate_kwargs property, just like all the new job classes. This required moving the _get_executor() function from the GenericJob to a static function.

@jan-janssen jan-janssen added the format_black reformat the code using the black standard label Jul 2, 2024
@jan-janssen
Copy link
Member Author

jan-janssen commented Jul 3, 2024

For some reason these changes sometimes causes the continuous integration environment to fail, so this should not be merged at the moment.

EDIT: Increasing the time out fixed this issue.
EDT: It is not fixed - so I move this pull request to draft state again.

@jan-janssen jan-janssen closed this Jul 5, 2024
@jan-janssen jan-janssen reopened this Jul 5, 2024
@jan-janssen jan-janssen marked this pull request as ready for review July 5, 2024 06:25
@jan-janssen jan-janssen requested a review from pmrv July 5, 2024 06:25
…nctioncontainer

# Conflicts:
#	pyiron_base/jobs/flex/pythonfunctioncontainer.py
@jan-janssen jan-janssen marked this pull request as draft July 5, 2024 07:07
@jan-janssen jan-janssen closed this Jul 5, 2024
@jan-janssen jan-janssen deleted the pythonfunctioncontainer branch July 5, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black reformat the code using the black standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants