Refactor and add doc string (done by ChatGPT) #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Due to the problem stated here I changed it to draft |
pmrv
reviewed
Jul 24, 2024
pmrv
reviewed
Jul 24, 2024
pmrv
reviewed
Jul 24, 2024
Co-authored-by: Marvin Poul <poul@mpie.de>
Co-authored-by: Marvin Poul <poul@mpie.de>
for more information, see https://pre-commit.ci
|
Can I merge this one? |
pmrv
approved these changes
Jul 25, 2024
Co-authored-by: Marvin Poul <poul@mpie.de>
|
The executor test is failing but it has nothing to do with this PR so I merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I asked ChatGPT to add doc strings and refactor it. I don't know if it works.