Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Coalesce fix #1042

Merged
merged 5 commits into from
Mar 14, 2022
Merged

[ENH] Coalesce fix #1042

merged 5 commits into from
Mar 14, 2022

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented Mar 13, 2022

Please describe the changes proposed in the pull request:

  • coalesce only needs bfill

**This PR improves coalesce **

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.rst.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@samukweku samukweku self-assigned this Mar 13, 2022
@ericmjl
Copy link
Member

ericmjl commented Mar 13, 2022

@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #1042 (e819bed) into dev (88f5479) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1042   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files          77       77           
  Lines        2888     2888           
=======================================
  Hits         2821     2821           
  Misses         67       67           

@ericmjl ericmjl merged commit aa01bed into dev Mar 14, 2022
@ericmjl
Copy link
Member

ericmjl commented Mar 14, 2022

LGTM, thank you @samukweku!

@ericmjl ericmjl deleted the coalesce_fix branch March 14, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants