Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyg version constraint in CI envs #357

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Add pyg version constraint in CI envs #357

merged 1 commit into from
Mar 27, 2023

Conversation

NYXFLOWER
Copy link
Collaborator

Fixes test issue in Actions.

Description

This PR will fix the dependency library issue for testing test_gcn_encoder-- causing "AttributeError: module 'torch' has no attribute 'sparse_csc'" in torch_geometric/utils/sparse.py:68.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • In-line docstrings updated.
  • Source for documentation at docs manually updated for new API.

@NYXFLOWER NYXFLOWER changed the title Add pyg version in CI envs Add pyg version constrain in CI envs Mar 27, 2023
@haipinglu haipinglu changed the title Add pyg version constrain in CI envs Add pyg version constraint in CI envs Mar 27, 2023
@NYXFLOWER
Copy link
Collaborator Author

In the testing environment, torch version 1.11.0 is compatible with pyg version 2.2.0. The issue stems from installing pyg version 2.3.0, which requires torch >= 1.13.0.

@codecov-commenter
Copy link

Codecov Report

Merging #357 (2924b9f) into main (b5946ea) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files          48       48           
  Lines        5130     5130           
=======================================
  Hits         4688     4688           
  Misses        442      442           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@haipinglu haipinglu merged commit 81dc1c5 into main Mar 27, 2023
@haipinglu haipinglu deleted the fix_gripnet_text branch March 27, 2023 21:55
This was referenced Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants