Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not only TensorType for Intput-Output params #102

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

ikrivosheev
Copy link
Contributor

@ikrivosheev ikrivosheev commented Oct 17, 2023

Hello! When I tried to create Session I got error:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: PointerShouldNotBeNull("CastTypeInfoToTensorInfo")'

I made small research and find java bindings for onnxruntime: https://github.com/microsoft/onnxruntime/blob/6832b688a2848f64d4d43ac0084c6609aa0203bc/java/src/main/native/OrtJniUtil.c.

I made something close to the implementation.

@ikrivosheev ikrivosheev changed the title Feature/params v2 Not only Tensor Intput-Output params Oct 17, 2023
@ikrivosheev ikrivosheev changed the title Not only Tensor Intput-Output params Not only TensorType for Intput-Output params Oct 17, 2023
@ikrivosheev
Copy link
Contributor Author

This is breaking changes for API. If it's ok - I can fix tests. Or I'm open to suggestions)

@ikrivosheev
Copy link
Contributor Author

Well, I think it can be related to: #30

Copy link
Member

@decahedron1 decahedron1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start for supporting sequences & maps! I'd like to merge this into the v2 branch since it is a breaking API change, could you port these changes over to there? I think it would require creating a new PR.

@ikrivosheev
Copy link
Contributor Author

This is a great start for supporting sequences & maps! I'd like to merge this into the v2 branch since it is a breaking API change, could you port these changes over to there? I think it would require creating a new PR.

Yes, I will do it.

@ikrivosheev ikrivosheev changed the base branch from main to v2 October 18, 2023 07:19
@ikrivosheev
Copy link
Contributor Author

@decahedron1 I rebased from v2 branch)

@decahedron1 decahedron1 merged commit de7b70c into pykeio:v2 Oct 18, 2023
1 of 7 checks passed
@ikrivosheev ikrivosheev deleted the feature/params_v2 branch October 18, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants