Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user.get_weekly_artist_charts #258

Merged
merged 2 commits into from
Apr 5, 2018
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Apr 5, 2018

Fixes #257.

Changes proposed in this pull request:

  • When building the charts from the response from Last.fm, it was using some common code for charts for artists, albums and tracks.
  • It was creating artist, album or track objects by passing it the artist and name (and network).
  • But that only makes sense for album and track. For artists, there is no artist field, the name is the artist's name.

@codecov
Copy link

codecov bot commented Apr 5, 2018

Codecov Report

Merging #258 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files           1        1           
  Lines        1199     1199           
=======================================
  Hits         1146     1146           
  Misses         53       53
Impacted Files Coverage Δ
pylast/__init__.py 95.57% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb1ce2...892acd6. Read the comment docs.

@hugovk hugovk merged commit 72cdd8b into master Apr 5, 2018
@hugovk hugovk deleted the fix-user.get_weekly_artist_charts branch April 5, 2018 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant