This repository has been archived by the owner on Mar 21, 2019. It is now read-only.
Add bytes_mode flag to NonblockingLDAPObject and ReconnectLDAPObject #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some fork-related commits in this pull request. Since I cannot modify the target branch, I created a new (clean) pull request at #73. Sorry for the inconvenience. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7, a backwards compatibility mode for Python 2 was implemented by adding a new parameter
bytes_modeto the SimpleLDAPObject constructor.With this commit, the parameter
bytes_modeis added to the constructors of NonblockingLDAPObject and ReconnectLDAPObject (which is then purely passed to the SimpleLDAPObject constructor). This enables the use of these objects under Python 2.