Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes in fake measurement, full response and corrections #404

Merged
merged 6 commits into from
Nov 4, 2022

Conversation

JoschD
Copy link
Member

@JoschD JoschD commented Nov 1, 2022

Fullresponse Path was not converted to Path() instance. Fixed

@JoschD JoschD requested a review from fsoubelet November 1, 2022 14:26
@JoschD JoschD added the Type: Bug Something isn't working as it should. label Nov 1, 2022
@JoschD JoschD self-assigned this Nov 1, 2022
@codeclimate
Copy link

codeclimate bot commented Nov 4, 2022

Code Climate has analyzed commit caa3f40 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 87.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.4% (0.0% change).

View more on Code Climate.

@JoschD JoschD changed the title Fix correction fullrespose as path Minor fixes in fake model, full response and corrections Nov 4, 2022
@JoschD JoschD changed the title Minor fixes in fake model, full response and corrections Minor fixes in fake measurement, full response and corrections Nov 4, 2022
Copy link
Contributor

@Mael-Le-Garrec Mael-Le-Garrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of those present changes.

@JoschD JoschD merged commit 61da514 into master Nov 4, 2022
@JoschD JoschD deleted the fix_correction_fullrespose_as_path branch November 4, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants