Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/bbs converter coupling fix #410

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Conversation

JoschD
Copy link
Member

@JoschD JoschD commented Mar 17, 2023

Fixes #409

@JoschD JoschD added Type: Feature A (suggetion for a) new feature or enhancement in functionality. Bugfix labels Mar 17, 2023
@JoschD JoschD self-assigned this Mar 17, 2023
@JoschD JoschD marked this pull request as draft March 17, 2023 12:05
@codeclimate
Copy link

codeclimate bot commented Mar 20, 2023

Code Climate has analyzed commit f30b921 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.3%.

View more on Code Climate.

@JoschD JoschD marked this pull request as ready for review March 21, 2023 09:07
@JoschD
Copy link
Member Author

JoschD commented Mar 21, 2023

tested with GUI. works

@JoschD JoschD merged commit b207708 into master Mar 21, 2023
@JoschD JoschD deleted the bug/bbs_converter_coupling_fix branch March 21, 2023 12:28
@pylhctokens pylhctokens added the Type: Bug Something isn't working as it should. label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as it should. Type: Feature A (suggetion for a) new feature or enhancement in functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: BBS2OMC3 converter - Add missing coupling columns
4 participants