Improve brain for typing.Callable + typing.Type #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 28, 2021
cdce8p
changed the title
cdce8p
commented
Sep 28, 2021
| @@ -232,9 +232,7 @@ def _looks_like_typing_alias(node: Call) -> bool: | |||
| and node.func.name == "_alias" | |||
| and ( | |||
| # _alias function works also for builtins object such as list and dict | |||
| isinstance(node.args[0], Attribute) | |||
| or isinstance(node.args[0], Name) | |||
| and node.args[0].name != "type" | |||
There was a problem hiding this comment.
Noticed that type was excluded as well. This was originally added with #921, I couldn't however find a good reason to keep it that way. It works as expected even for type. Could be that the type brain improved since then, idk.
I did run the acceptance test that caused headaches a while back. Worked without problems.
pytest -m acceptance -k "test_libmodule[typing.py]"
Pierre-Sassoulas
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to
typing.Tuple-typing.Callableis a special alias as well. Added some brain logic to help infer it correctly.Type of Changes
Related Issue
Ref: pylint-dev/pylint#3507 (comment)
Ref: pylint-dev/pylint#5087
Pylint PR with additional tests: pylint-dev/pylint#5089
Pylint PR for additional typing tests: pylint-dev/pylint#5090