Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a comment about missing __spec__ on PyPy #1758

Merged
merged 1 commit into from
Aug 28, 2022
Merged

Add a comment about missing __spec__ on PyPy #1758

merged 1 commit into from
Aug 28, 2022

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • Write a good description on what the PR does.

Description

Type of Changes

Type
✓ 🔨 Refactoring

Related Issue

Follow up to #1757 (comment).

@DanielNoord DanielNoord added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Aug 28, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2943670972

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.347%
Totals Coverage Status
Change from base Build 2940627623: 0.0%
Covered Lines: 9714
Relevant Lines: 10519
💛 - Coveralls

jacobtylerwalls
jacobtylerwalls approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks Daniel!

(Good to have, but I don't know that we need to backport documentation comments.)

@Pierre-Sassoulas Pierre-Sassoulas merged commit ad80ee2 into pylint-dev:main Aug 28, 2022
@DanielNoord DanielNoord deleted the follow-up branch August 28, 2022 20:21
@DanielNoord
Copy link
Collaborator Author

@Pierre-Sassoulas @jacobtylerwalls I thought since we're likely to fix others bugs here back porting this as well would avoid any merge conflicts.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.12.5 milestone Aug 28, 2022
@Pierre-Sassoulas
Copy link
Member

Fair enough !

Pierre-Sassoulas pushed a commit that referenced this pull request Aug 28, 2022
@DanielNoord @Pierre-Sassoulas
Add a comment about missing __spec__ on PyPy (#1758)
3d102ff
Pierre-Sassoulas pushed a commit that referenced this pull request Aug 29, 2022
@DanielNoord @Pierre-Sassoulas
Add a comment about missing __spec__ on PyPy (#1758)
92529b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Milestone
2.12.5
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielNoord @coveralls @Pierre-Sassoulas @jacobtylerwalls