Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on PyPy 3.10 #2222

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Test on PyPy 3.10 #2222

merged 3 commits into from
Jun 22, 2023

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

CI is failing on main and all PRs because pytest can't run on the newest PyPy 3.9 image. When the image came out, 3.10 also became available for the first time.

Let's just run on 3.10 to unblock CI. Two PyPy versions is fine?

@jacobtylerwalls jacobtylerwalls added Maintenance Discussion or action around maintaining astroid or the dev workflow PyPy backport maintenance/2.15.x labels Jun 22, 2023
DanielNoord
DanielNoord previously approved these changes Jun 22, 2023
.github/workflows/ci.yaml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #2222 (e0f2d82) into main (842548d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2222      +/-   ##
==========================================
+ Coverage   92.80%   92.82%   +0.02%     
==========================================
  Files          94       94              
  Lines       10840    10836       -4     
==========================================
- Hits        10060    10059       -1     
+ Misses        780      777       -3     
Flag Coverage Ξ”
linux 92.63% <100.00%> (+0.07%) ⬆️
pypy 91.25% <100.00%> (+3.17%) ⬆️
windows 92.42% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
astroid/nodes/node_classes.py 95.46% <100.00%> (+0.19%) ⬆️

... and 3 files with indirect coverage changes

Co-authored-by: DaniΓ«l van Noord <13665637+DanielNoord@users.noreply.github.com>
@jacobtylerwalls jacobtylerwalls merged commit efb34f2 into pylint-dev:main Jun 22, 2023
@jacobtylerwalls jacobtylerwalls deleted the pypy310 branch June 22, 2023 21:06
@github-actions
Copy link
Contributor

The backport to maintenance/2.15.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-maintenance/2.15.x maintenance/2.15.x
# Navigate to the new working tree
cd .worktrees/backport-maintenance/2.15.x
# Create a new branch
git switch --create backport-2222-to-maintenance/2.15.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 efb34f2b84c9f019ffceacef3448d8351563b6a2
# Push it to GitHub
git push --set-upstream origin backport-2222-to-maintenance/2.15.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-maintenance/2.15.x

Then, create a pull request where the base branch is maintenance/2.15.x and the compare/head branch is backport-2222-to-maintenance/2.15.x.

@jacobtylerwalls jacobtylerwalls added this to the 2.15.6 milestone Jun 22, 2023
@jacobtylerwalls
Copy link
Member Author

@DanielNoord I was able to resolve the underlying issue with PyPy 3.9 by deleting the cached image from each project's Actions environment.

So I'll avoid backporting this or doing the same in pylint.

Still, I think it's okay to just test on lowest and highest in astroid for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow PyPy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants