Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Modernize, MOAR Pythons, GH-Actions #1

Merged
merged 2 commits into from
Oct 14, 2023
Merged

Conversation

stdedos
Copy link
Collaborator

@stdedos stdedos commented Feb 24, 2023

No description provided.

@stdedos stdedos force-pushed the ci/improve/use-gh-actions branch 6 times, most recently from a3bc306 to 913c933 Compare February 24, 2023 09:50
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
@stdedos
Copy link
Collaborator Author

stdedos commented Oct 13, 2023

Should I drop travis too? ... Unless we have a subscription?

@Pierre-Sassoulas
Copy link
Member

Yeah definitely should get rid of travis for github actions. Maybe you can use the job from pylint directly (pypy etc.) ?

@stdedos stdedos force-pushed the ci/improve/use-gh-actions branch 4 times, most recently from 0f27581 to 300774b Compare October 13, 2023 15:15
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@6267638). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   86.50%           
=========================================
  Files             ?       33           
  Lines             ?      400           
  Branches          ?       81           
=========================================
  Hits              ?      346           
  Misses            ?       50           
  Partials          ?        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented Oct 13, 2023

Here's a starter pre-commit file need to be in .pre-commit-config.yaml

repos:
  - repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v4.5.0
    hooks:
      - id: trailing-whitespace
      - id: end-of-file-fixer

@stdedos
Copy link
Collaborator Author

stdedos commented Oct 13, 2023

I'm going to fix it next MR 🙏

I already threw a lot of stuff here

@stdedos
Copy link
Collaborator Author

stdedos commented Oct 14, 2023

I guess this will have to do for now. Can I get a second thumbs-up?

… only `pylint<3`, coverage at Codecov, drop other CI

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! I'll do the release job and add pre-commit

@stdedos stdedos merged commit 6be0547 into master Oct 14, 2023
38 of 39 checks passed
@stdedos stdedos added enhancement New feature or request CI labels Oct 14, 2023
@stdedos stdedos added this to the Release 1.1.x milestone Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants