Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .pre-commit-config.yaml #4

Merged
merged 3 commits into from
Oct 14, 2023

Conversation

stdedos
Copy link
Collaborator

@stdedos stdedos commented Oct 14, 2023

Store all tools' configurations in pyproject.toml,
even if right now only the setup.py file is used.

Keep .pylintrc separately.
It is 300 lines; default --generate-toml-config gives 600 😅

Comment-out hooks that need >0 work to be green.

Signed-off-by: Stavros Ntentos 133706+stdedos@users.noreply.github.com

Enable https://github.com/asottile/pyupgrade + .git-blame-ignore-revs

Signed-off-by: Stavros Ntentos 133706+stdedos@users.noreply.github.com

@stdedos
Copy link
Collaborator Author

stdedos commented Oct 14, 2023

@Pierre-Sassoulas here is the .pre-commit-config.yaml. Feel free to extend it, if you wish 🙏

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6be0547) 86.50% compared to head (ff18b58) 87.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   86.50%   87.00%   +0.50%     
==========================================
  Files          33       33              
  Lines         400      400              
  Branches       81       81              
==========================================
+ Hits          346      348       +2     
+ Misses         50       48       -2     
  Partials        4        4              
Files Coverage Δ
tests/base_tester.py 88.70% <100.00%> (ø)
...annot-enumerate-pytest-fixtures/no_such_package.py 28.57% <ø> (ø)
tests/input/conftest.py 71.42% <100.00%> (ø)
...ests/input/deprecated-pytest-yield-fixture/func.py 71.42% <100.00%> (ø)
tests/input/unused-import/same_name_decorator.py 80.00% <100.00%> (ø)
...useless-pytest-mark-decorator/not_pytest_marker.py 78.57% <100.00%> (ø)
tests/test_cannot_enumerate_fixtures.py 100.00% <100.00%> (ø)
tests/test_no_member.py 100.00% <100.00%> (ø)
tests/test_pytest_fixture_positional_arguments.py 100.00% <100.00%> (ø)
tests/test_pytest_mark_for_fixtures.py 100.00% <100.00%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much work done here 😄 ! Enabling more linters can wait for later imo

.git-blame-ignore-revs Outdated Show resolved Hide resolved
.pylintrc Outdated Show resolved Hide resolved
.pylintrc Show resolved Hide resolved
.git-blame-ignore-revs Outdated Show resolved Hide resolved
@Pierre-Sassoulas
Copy link
Member

WDYM? Remove the sha1 from the file AKA "not-ignore" its blame?

My bad I thougth it was a mistake in a changelog 😅

Store all tools' configurations in `pyproject.toml`,
even if right now only the `setup.py` file is used.

Keep `.pylintrc` separately.
It is 300 lines; default `--generate-toml-config` gives 600 😅

Comment-out hooks that need >0 work to be green.

Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
@stdedos stdedos added the enhancement New feature or request label Oct 14, 2023
@stdedos stdedos merged commit 5ee69ce into pylint-dev:master Oct 14, 2023
21 checks passed
@stdedos stdedos added the CI label Oct 15, 2023
@stdedos stdedos added this to the Release 1.1.x milestone Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants