Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for typing.final #3197

Closed
PCManticore opened this issue Oct 17, 2019 · 1 comment · Fixed by #5133
Closed

Add support for typing.final #3197

PCManticore opened this issue Oct 17, 2019 · 1 comment · Fixed by #5133
Labels
Checkers Related to a checker Good first issue Friendly and approachable by new contributors Hacktoberfest Help wanted 🙏 Outside help would be appreciated, good for new contributors
Milestone
2.12.0

Comments

@PCManticore
Copy link
Contributor

Python 3.8 added the concept of final methods which cannot be overridden: https://docs.python.org/3/library/typing.html#typing.final We should add a checker for that since it's almost trivial to detect violations of these using pylint.
@PCManticore PCManticore added Checkers Related to a checker Good first issue Friendly and approachable by new contributors labels Oct 17, 2019
@thecnoNSMB
Copy link

Also typing.Final, which is much the same but for data: https://docs.python.org/3/library/typing.html#typing.Final

@Pierre-Sassoulas Pierre-Sassoulas added the Help wanted 🙏 Outside help would be appreciated, good for new contributors label Mar 2, 2021
mbyrnepr2 added a commit to mbyrnepr2/pylint that referenced this issue Oct 9, 2021
@mbyrnepr2
Add checkers for typing.final for Python version 3.8 or later
37b8587 
- overridden-final-method
- subclassed-final-class

Closes pylint-dev#3197
mbyrnepr2 added a commit to mbyrnepr2/pylint that referenced this issue Oct 9, 2021
@mbyrnepr2
Add checkers for typing.final for Python version 3.8 or later
68d0998 
- overridden-final-method
- subclassed-final-class

Closes pylint-dev#3197
@mbyrnepr2 mbyrnepr2 mentioned this issue Oct 9, 2021
Merged
mbyrnepr2 added a commit to mbyrnepr2/pylint that referenced this issue Oct 9, 2021
@mbyrnepr2
Add checkers for typing.final for Python version 3.8 or later
43741b8 
- Move checker logic to its own method
- tuple -> list to be consistent with the existing module style
- Doc formatting tweak

    Closes pylint-dev#3197
mbyrnepr2 added a commit to mbyrnepr2/pylint that referenced this issue Oct 9, 2021
@mbyrnepr2
Add checkers for typing.final for Python version 3.8 or later
f7e2545 
- Re-add dot in docstring

Closes pylint-dev#3197
mbyrnepr2 added a commit to mbyrnepr2/pylint that referenced this issue Oct 9, 2021
@mbyrnepr2
Add checkers for typing.final for Python version 3.8 or later
59694d4 
- Remove accidentally committed file

Closes pylint-dev#3197
mbyrnepr2 added a commit to mbyrnepr2/pylint that referenced this issue Oct 10, 2021
@mbyrnepr2
Add checkers for typing.final for Python version 3.8 or later
5447af8 
- Return early if not PY38

Closes pylint-dev#3197
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.12.0 milestone Oct 10, 2021
Pierre-Sassoulas pushed a commit that referenced this issue Oct 10, 2021
@mbyrnepr2
Add checkers for typing.final for Python version 3.8 or later (#5133)
087fe68 
* Add checkers for typing.final for Python version 3.8 or later

- overridden-final-method
- subclassed-final-class

Closes #3197
@mbyrnepr2 mbyrnepr2 mentioned this issue Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Checkers Related to a checker Good first issue Friendly and approachable by new contributors Hacktoberfest Help wanted 🙏 Outside help would be appreciated, good for new contributors
Projects
None yet
Milestone
2.12.0
Development

Successfully merging a pull request may close this issue.

Add checkers for typing.final for Python version 3.8 or later mbyrnepr2/pylint
3 participants
@PCManticore @Pierre-Sassoulas @thecnoNSMB