Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annotations changes on new branch. #2338

Merged
merged 5 commits into from
Aug 21, 2018
Merged

annotations changes on new branch. #2338

merged 5 commits into from
Aug 21, 2018

Conversation

sushobhit27
Copy link
Contributor

PCManticore
PCManticore reviewed Jul 24, 2018
View reviewed changes
tox.ini Outdated
mypy

commands =
python -m mypy {envsitepackagesdir}/pylint/checkers --ignore-missing-imports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe run it against the current directory instead of the package installed in site-packages?

@sushobhit27 sushobhit27 mentioned this pull request Jul 25, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 90.039% when pulling a8423ca on sushobhit27:fix_annotate into 28a2690 on PyCQA:master.

@coveralls
Copy link

coveralls commented Aug 17, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 90.224% when pulling ea23da1 on sushobhit27:fix_annotate into 28a2690 on PyCQA:master.

@sushobhit27
annotate checkers/utils.py
ea23da1 
fix mypy and lint issues after annotating
@PCManticore
Copy link
Contributor

This is great stuff @sushobhit27 ! Thank you so much for tackling it! I think we can merge it as is for now, and new annotations can be added later on in separate PRs. I can't wait to use it as well. :)

@PCManticore PCManticore merged commit d37e2b7 into pylint-dev:master Aug 21, 2018
@PCManticore PCManticore mentioned this pull request Aug 21, 2018
Closed
@DanielNoord DanielNoord mentioned this pull request Mar 12, 2022
Merged
2 tasks
@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow and removed Work in progress labels Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PCManticore PCManticore PCManticore left review comments

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sushobhit27 @coveralls @PCManticore @Pierre-Sassoulas