-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check to make sure only strings are assigned to __name__ #3271
Add check to make sure only strings are assigned to __name__ #3271
Conversation
Putting this in as a draft to check I'm going in the right direction. I'd like to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for sending this PR! Overall it's looking great, left a bunch of comments to be addressed before we can pull this in.
Thank you for the advice and examples Claudiu! I'm hoping to take a stab at this this weekend. |
…mer to copyright list
1 similar comment
Thanks a lot for the patch @ninezerozeronine ! |
Steps
doc/whatsnew/<current release.rst>
.Description
This adds a new check to make sure that only strings are assigned to
__name__
attributes.Type of Changes
Related Issue
Closes #583