-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toward python39 #3959
Toward python39 #3959
Conversation
from this version, potential error when using star operator are detected in the parser and no more at compile time.
Maybe not the right place to discuss this, but shouldn't we also drop python 3.5 ? It has ceased to be supported since September 2020. |
Yes, this was briefly discussed in another issue. I said I would tackle it but did not. I can probably look at it in a week or two, if nobody beats me to it. :) Anyway, we can discuss that in this specifically created new issue: #3965. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than relaxing the astroid version so the CI is green, this looks good to go.
1 similar comment
Thanks for all the work here ♥ |
Steps
Description
This PR is an attempt to deal with
python 3.9
. The functional tests that where failing are now successful thanks to pylint-dev/astroid#858. Thestar_needs_assignment_py35
is, IMHO, useless forpython3.9
, because potential problem with star operator is now detected in the new parser used by python3.9. (with previous version it was detected only at compile time).Related Issue
Closes #3895 #3876