Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toward python39 #3959

Merged
merged 6 commits into from
Dec 29, 2020
Merged

Toward python39 #3959

merged 6 commits into from
Dec 29, 2020

Conversation

hippo91
Copy link
Contributor

@hippo91 hippo91 commented Nov 28, 2020

Steps

  • Write a good description on what the PR does.

Description

This PR is an attempt to deal with python 3.9. The functional tests that where failing are now successful thanks to pylint-dev/astroid#858. The star_needs_assignment_py35 is, IMHO, useless for python3.9, because potential problem with star operator is now detected in the new parser used by python3.9. (with previous version it was detected only at compile time).

Related Issue

Closes #3895 #3876

@Pierre-Sassoulas
Copy link
Member

Maybe not the right place to discuss this, but shouldn't we also drop python 3.5 ? It has ceased to be supported since September 2020.

@dbaty
Copy link
Contributor

dbaty commented Dec 2, 2020

Maybe not the right place to discuss this, but shouldn't we also drop python 3.5 ? It has ceased to be supported since September 2020.

Yes, this was briefly discussed in another issue. I said I would tackle it but did not. I can probably look at it in a week or two, if nobody beats me to it. :) Anyway, we can discuss that in this specifically created new issue: #3965.

Copy link
Contributor

@PCManticore PCManticore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than relaxing the astroid version so the CI is green, this looks good to go.

pylint/__pkginfo__.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 90.862% when pulling bacbf62 on hippo91:toward_python39 into 17325f2 on PyCQA:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 90.862% when pulling bacbf62 on hippo91:toward_python39 into 17325f2 on PyCQA:master.

@hippo91 hippo91 merged commit b3b8ed2 into pylint-dev:master Dec 29, 2020
@hippo91 hippo91 deleted the toward_python39 branch December 29, 2020 10:35
@JulienPalard
Copy link
Contributor

Thanks for all the work here ♥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing functional tests with Python 3.9
6 participants