Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[duplicate-code] Fix ignored empty functions by similarities checker with ignore-signatures option enabled #4669

Merged
merged 1 commit into from
Jul 5, 2021
Merged

[duplicate-code] Fix ignored empty functions by similarities checker with ignore-signatures option enabled #4669

merged 1 commit into from
Jul 5, 2021

Conversation

mhumetskyi
Copy link
Contributor

Description

Similarities checker with "ignore-signatures" option enabled ignores functions with empty bodies.
This PR fixes this bug.

Type of Changes

Type
✓ 🐛 Bug fix

Related Issue

Closes #4652

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.038% when pulling 6484c9c on mhumetskyi:issue-4652 into c2d03c6 on PyCQA:main.

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank a lot, this was easier to fix than I thought ! Too bad I did not see it. But we now have better tests thank to you :)

@Pierre-Sassoulas Pierre-Sassoulas added Bug 🪲 False Positive 🦟 A message is emitted but nothing is wrong with the code labels Jul 5, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.9.4 milestone Jul 5, 2021
@Pierre-Sassoulas Pierre-Sassoulas merged commit fc3fe81 into pylint-dev:main Jul 5, 2021
@mhumetskyi mhumetskyi deleted the issue-4652 branch July 5, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Bug 🪲 False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.9.4
Development

Successfully merging this pull request may close these issues.

Similarities checker with "ignore-signatures" option enabled ignores functions with docstring-only bodies
3 participants
@mhumetskyi @coveralls @Pierre-Sassoulas