Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend unspecified-encoding checker #4946

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
✨ New feature

Description

The unspecified-encoding checker now also checks calls to pathlib.Path().read_text()
and pathlib.Path().write_text()
This closes #4945

The ``unspecified-encoding`` checker now also checks calls to ``pathlib.Path().read_text()``
and ``pathlib.Path().write_text()``
This closes pylint-dev#4945
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.11.0 milestone Sep 1, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1189099892

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.062%

Totals Coverage Status
Change from base Build 1189060335: 0.0%
Covered Lines: 13212
Relevant Lines: 14197

💛 - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pierre-Sassoulas Pierre-Sassoulas merged commit 832db06 into pylint-dev:main Sep 1, 2021
@DanielNoord DanielNoord deleted the encoding-fix branch September 8, 2021 19:30
alecandido added a commit to NNPDF/eko that referenced this pull request Jan 13, 2022
alecandido added a commit to NNPDF/eko that referenced this pull request Jan 14, 2022
* develop: (40 commits)
  Add DGLAP refs
  Typos in docs
  small fixes on docs
  See pylint-dev/pylint#4946
  Fix iterations, and broken picky test
  Last batch of open updates
  Fix other file warnings
  Fix output warnings
  Add RGE abbrev
  Other 2 pylint fixes
  Make MSbar consistent
  Some easy pylint fixes
  Polish code and docs
  Remove version test, non present ignored folder
  Fix LHA ref
  Improve doc
  more docs
  Msbar apfel bench now running
  Allow for VFNS when solving msbar mass RGE
  Fix docs typos in theory/pqcd
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make unspecified-encoding work for pathlib.Path.write_text()
3 participants