Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false-positive useless-suppression for line-too-long #5077

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
🐛 Bug fix

Description

Also changes add_ignored_message() to make nodes parameter optional.
Closes #4212

Also changes ``add_ignored_message()`` to make ``nodes`` parameter
optional.
Closes pylint-dev#4212
@DanielNoord DanielNoord added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Sep 27, 2021
@DanielNoord DanielNoord added this to the 2.11.2 milestone Sep 27, 2021
@coveralls
Copy link

coveralls commented Sep 27, 2021

Pull Request Test Coverage Report for Build 1281320835

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 93.098%

Totals Coverage Status
Change from base Build 1281318259: 0.001%
Covered Lines: 13367
Relevant Lines: 14358

💛 - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

if mobj:
if not self.is_line_length_check_activated(mobj):
# the line length check is deactivated, we can stop here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we could not 😄

@Pierre-Sassoulas Pierre-Sassoulas merged commit 20304a6 into pylint-dev:main Sep 28, 2021
@DanielNoord DanielNoord deleted the suppression branch September 28, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False-positive I0021: Useless suppression of 'line-too-long' (useless-suppression)
3 participants